[llvm-commits] [PATCH] BasicBlock Autovectorization Pass

[Tobias Grosser]

On 11/01/2011 06:32 PM, Hal Finkel wrote:
> Any objections to me committing this? [And some relevant docs changes] I
> think that it is ready at this point.

First of all. I think it is great to see work starting on an 
autovectorizer for LLVM. Unfortunately I did not have time to test your 
vectorizer pass intensively, but here my first comments:

1. This patch breaks the --enable-shared/BUILD_SHARED_LIBS build. The
    following patch fixes this for cmake:
    0001-Add-vectorizer-to-libraries-used-by-Transforms-IPO.patch

    Can you check the autoconf build with --enable-shared?

2. Did you run this pass on the llvm test-suite? Does your vectorizer
    introduce any correctness regressions? What are the top 10 compile
    time increases/decreases. How about run time?

3. I did not really test this intensively, but I had the feeling the
    compile time increase for large basic blocks is quite a lot.
    I still need to extract a test case. Any comments on the complexity
    of your vectorizer?

I plan to look into your vectorizer during the next couple of 
days/weeks, but will most probably not have the time to do this tonight. 
Sorry. :-(

Cheers
Tobi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-vectorizer-to-libraries-used-by-Transforms-IPO.patch
Type: text/x-diff
Size: 1316 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111101/63b8a858/attachment.patch>