[llvm-commits] patch: pick direct or indirect strings in DWARF

[Nick Lewycky]

Eric Christopher wrote:
>
> On Oct 26, 2011, at 5:37 PM, Nick Lewycky wrote:
>
>> New patch! Updates tests and adds new test. Tested on Linux and Darwin.
>>
>> The previous patch looked like it worked on linux but didn't (readelf -w on the .o file was fine, but it didn't have relocations so after linking the debug info in the result was wrong). Darwin needs to not have relocations for its string pool entries, while linux needs to have them.
>>
>> Please review!
>
> Looks good. As we chatted about on IRC I don't know that the size savings is worth having to worry about str vs strp for lookup so if you could just make it do strp that'd be awesome.
>
> Thanks for this! It looks great!

Thanks for the speedy review! Committed in r143097.

As we discussed over IRC, I submitted as-is and will look into changing 
it to always use strp.

Nick