[llvm-commits] [llvm] r143001 - /llvm/trunk/lib/CodeGen/BranchFolding.cpp

Bill Wendling wendling at apple.com
Wed Oct 26 11:30:55 PDT 2011


On Oct 26, 2011, at 12:38 AM, Duncan Sands wrote:

> Hi Bill,
> 
>> Reapply r142920 with fix:
>> 
>> An MBB which branches to an EH landing pad shouldn't be considered for tail merging.
>> 
>> In SjLj EH, the jump to the landing pad is not done explicitly through a branch
>> statement. The EH landing pad is added as a successor to the throwing
>> BB. Because of that however, the branch folding pass could mistakenly think that
>> it could merge the throwing BB with another BB. This isn't safe to do.
>> <rdar://problem/10334833>
> 
> testcase?
> 
Unfortunately, the testcase is way too large to go into the regression suite.

-bw




More information about the llvm-commits mailing list