[llvm-commits] [llvm] r142530 - in /llvm/trunk: lib/Target/ARM/ARMISelLowering.cpp test/CodeGen/ARM/2011-10-18-DisableMovtSize.ll

[Evan Cheng]

On Oct 26, 2011, at 9:50 AM, Owen Anderson wrote:

> 
> On Oct 26, 2011, at 12:37 AM, James Molloy wrote:
> 
>> I also heavily dislike the Darwin-specific stuff in the backend and the
>> whole idea of "We don't want to do this for Darwin" - if something is a
>> negative tradeoff, have an appropriate target-independent knob that can be
>> turned to a different position for Darwin.
> 
> +1
> 
> I think the real issue here is that we don't have a way to distinguish -Os vs. -Oz at the IR level.  Perhaps we need a new function attribute to distinguish the two, though I don't know a good name for it offhand.  Then "We don't want this for Darwin" just becomes a policy decision in the driver.

I agree with this. We should either 1) rename the current attribute OptimizeForSize and add another one for -Oz or 2) change the attribute so it's not true / false rather a OptimizeForSize level.

LLVM traditionally hasn't cared much about optimizing for size. I would love for someone to be the champion for this task and drive it.

Evan

> 
> --Owen
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits