[llvm-commits] [llvm] r143035 - /llvm/trunk/lib/Object/MachOObjectFile.cpp

Owen Anderson resistor at mac.com
Wed Oct 26 10:28:49 PDT 2011


Author: resistor
Date: Wed Oct 26 12:28:49 2011
New Revision: 143035

URL: http://llvm.org/viewvc/llvm-project?rev=143035&view=rev
Log:
The order of the two symbol listings in a Macho x86_64 subtractor relocation is reversed from what seems intuitive to me.

Modified:
    llvm/trunk/lib/Object/MachOObjectFile.cpp

Modified: llvm/trunk/lib/Object/MachOObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOObjectFile.cpp?rev=143035&r1=143034&r2=143035&view=diff
==============================================================================
--- llvm/trunk/lib/Object/MachOObjectFile.cpp (original)
+++ llvm/trunk/lib/Object/MachOObjectFile.cpp Wed Oct 26 12:28:49 2011
@@ -835,7 +835,9 @@
         if (error_code ec = getRelocationTargetName(RENext->Word1, SucName))
           report_fatal_error(ec.message());
 
-        fmt << Name << "-" << SucName;
+        // The X86_64_RELOC_UNSIGNED contains the minuend symbol,
+        // X86_64_SUBTRACTOR contains to the subtrahend.
+        fmt << SucName << "-" << Name;
       }
       case 6: // X86_64_RELOC_SIGNED1
         fmt << Name << "-1";





More information about the llvm-commits mailing list