[llvm-commits] [PATCH][Review request] Mips direct object generation patch #5 of 6

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Tue Oct 25 20:08:04 PDT 2011


Hi,

On Tue, Oct 25, 2011 at 10:24 PM, Carter, Jack <jcarter at mips.com> wrote:
> This is the fifth of 6 patches for Mips direct object generation.
>
>     lib/Target/Mips/MipsAsmPrinter.cpp
>
> The patch is attached.
>
> Jack

+      return;
+    }

Since you use "return" above, remove the "else" below.

+    else if (Opc == Mips::CPRESTORE) {
+      MCInstLowering.LowerCPRESTORE(MI, TmpInst0);
+      OutStreamer.EmitInstruction(TmpInst0);
+      return;
+    }
+  }

LGTM!

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc




More information about the llvm-commits mailing list