[llvm-commits] [llvm] r142523 - in /llvm/trunk/lib/TableGen: TGParser.cpp TGParser.h

[Eric Christopher]

On Oct 20, 2011, at 8:07 AM, David A. Greene wrote:

> Hal Finkel <hfinkel at anl.gov> writes:
> 
>> There are several ways of squashing local git commits together before
>> pushing them to the svn. See:
>> http://stackoverflow.com/questions/1408381/combine-local-git-commits-into-one-commit-with-git-svn
> 
> I don't think that's what we wanted to do in this case.  I deliberately
> kept these separate for review purposes.
> 
> As I understand it, people objected to a bunch of commits in a short
> amount of time.  I will throttle that next time.

Sort of. Basically you went away for a while and then dumped a huge amount of code in a short while on people, that's largely what my objection was in this case. Part of incremental changes is not just that the patches are small, but that you're trying to work on top of tree as opposed to doing code dumps no matter how small. It may sound like a fuzzy thing, and it is, but it's the difference between saying: "here's the next part of what i'm working on, what do you think?" and "here's everything that i've done for the last 3 months and I demand you look at it now because I'm blocked until you look at all of them!"

-eric