[llvm-commits] [llvm] r142176 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Bill Wendling isanbard at gmail.com
Tue Oct 18 13:07:25 PDT 2011


On Oct 18, 2011, at 12:51 PM, Andrew Trick wrote:

> On Oct 16, 2011, at 10:25 PM, Bill Wendling wrote:
>> Author: void
>> Date: Mon Oct 17 00:25:09 2011
>> New Revision: 142176
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=142176&view=rev
>> Log:
>> Add comment explaining that the order of processing doesn't matter here.
>> 
>> Modified:
>>   llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>> 
>> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=142176&r1=142175&r2=142176&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Mon Oct 17 00:25:09 2011
>> @@ -5893,6 +5893,7 @@
>>    PrevMBB = CurMBB;
>>  }
>> 
>> +  // N.B. the order the invoke BBs are processed in doesn't matter here.
>>  const ARMBaseInstrInfo *AII = static_cast<const ARMBaseInstrInfo*>(TII);
>>  const ARMBaseRegisterInfo &RI = AII->getRegisterInfo();
>>  const unsigned *SavedRegs = RI.getCalleeSavedRegs(MF);
> 
> Does the call to addSuccessor affect use list order? Do we care?
>    BB->addSuccessor(DispatchBB);
> 
It shouldn't matter. :)

-bw






More information about the llvm-commits mailing list