[llvm-commits] [llvm] r142288 - in /llvm/trunk: include/llvm/Target/TargetData.h lib/AsmParser/LLParser.cpp lib/Target/TargetData.cpp

[Chandler Carruth]

On Mon, Oct 17, 2011 at 4:17 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> On 10/17/2011 06:26 PM, Rafael Ávila de Espíndola wrote:
>
>> looks like this broke the build:
>>
>>
>> Linking CXX executable ../../bin/llvm-as
>> ../../lib/libLLVMAsmParser.a(**LLParser.cpp.o):/home/**
>> espindola/llvm/llvm/lib/**AsmParser/LLParser.cpp:**function
>> llvm::LLParser::**ParseTargetDefinition(): error: undefined reference to
>> 'llvm::TargetData::**parseSpecifier(llvm::**StringRef,
>> llvm::TargetData*)'
>> clang-3: error: linker command failed with exit code 1 (use -v to see
>> invocation)
>>
>
> It looks like all that was missing was the attached patch.
>
> Chandler, is it OK with the original patch?


As discussed in IRC, yes this is sufficient for the link command to succeed,
but it feels completely wrong for the LL parsing to depend on the target
library. I think this is a more fundamental layering issue. Currently
AsmParser only depends on Support and Core, and that seems reasonable. I
don't think something not in the VMCore should be required in order to parse
the IR.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111017/019d9811/attachment.html>