[llvm-commits] [llvm] r142286 - /llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll

[Lang Hames]

Not quite. Apparently the shell lines in the lit suite are tcl, which doesn't honor the embedded quote. This led to the trailing quote being passed through in the target data layout string. The parser used to swallow this silently, treating the resulting 'n32"' as zero and discard it. The new verifier barfed on it though (as it should).

- Lang.

On Oct 17, 2011, at 2:54 PM, Lang Hames wrote:

> Author: lhames
> Date: Mon Oct 17 16:54:43 2011
> New Revision: 142286
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=142286&view=rev
> Log:
> Fixed quoting on default data layout option.
> 
> Modified:
>    llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll
> 
> Modified: llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll?rev=142286&r1=142285&r2=142286&view=diff
> ==============================================================================
> --- llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll (original)
> +++ llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll Mon Oct 17 16:54:43 2011
> @@ -1,4 +1,4 @@
> -; RUN: opt < %s -default-data-layout="e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-n32" -simplify-libcalls -S | FileCheck %s
> +; RUN: opt < %s "-default-data-layout=e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-n32" -simplify-libcalls -S | FileCheck %s
> @.str1 = private constant [11 x i8] c"(){};[]&|:\00", align 4
> 
> ; check that simplify libcalls will not replace a call with one calling
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits