[llvm-commits] [llvm] r142018 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
Bill Wendling
isanbard at gmail.com
Fri Oct 14 17:28:06 PDT 2011
On Oct 14, 2011, at 5:15 PM, Jakob Stoklund Olesen wrote:
>
> On Oct 14, 2011, at 4:34 PM, Bill Wendling wrote:
>
>> + MIB.addReg(SavedRegs[i], RegState::Implicit | RegState::Define);
>
> Throw a dead flag in there as well since these are just clobbers.
>
Okie. :)
> Hehe:
>
LOL :-)
> Author: Bill Wendling <isanbard at gmail.com>
> Date: Wed May 13 14:33:08 2009
>
> Change MachineInstrBuilder::addReg() to take a flag instead of a list of
> booleans. This gives a better indication of what the "addReg()" is
> doing. Remembering what all of those booleans mean isn't easy, especially if you
> aren't spending all of your time in that code.
>
> @@ -23,6 +23,18 @@ namespace llvm {
>
> class TargetInstrDesc;
>
> +namespace RegState {
> + enum {
> + Define = 0x2,
> + Implicit = 0x4,
> + Kill = 0x8,
> + Dead = 0x10,
> + EarlyClobber = 0x20,
> + ImplicitDefine = Implicit | Define,
> + ImplicitKill = Implicit | Kill
> + };
> +}
> +
>
> /jakob
>
More information about the llvm-commits
mailing list