[llvm-commits] [llvm] r141713 - in /llvm/trunk: lib/Transforms/Scalar/ScalarReplAggregates.cpp test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll

[Cameron Zwarich]

Author: zwarich
Date: Tue Oct 11 16:26:40 2011
New Revision: 141713

URL: http://llvm.org/viewvc/llvm-project?rev=141713&view=rev
Log:
Fix PR11106 by correcting a typo that has been in the code for over a year. This
would have never worked, since the element type of a vector type is never a
vector type. Also fix the conditional to be more direct in checking whether
EltTy is a vector type.

Added:
    llvm/trunk/test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp?rev=141713&r1=141712&r2=141713&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp Tue Oct 11 16:26:40 2011
@@ -2144,8 +2144,8 @@
           assert(StoreVal->getType() == ValTy && "Type mismatch!");
 
           // If the requested value was a vector constant, create it.
-          if (EltTy != ValTy) {
-            unsigned NumElts = cast<VectorType>(ValTy)->getNumElements();
+          if (EltTy->isVectorTy()) {
+            unsigned NumElts = cast<VectorType>(EltTy)->getNumElements();
             SmallVector<Constant*, 16> Elts(NumElts, StoreVal);
             StoreVal = ConstantVector::get(Elts);
           }

Added: llvm/trunk/test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll?rev=141713&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll (added)
+++ llvm/trunk/test/Transforms/ScalarRepl/2011-10-11-VectorMemset.ll Tue Oct 11 16:26:40 2011
@@ -0,0 +1,22 @@
+; RUN: opt < %s -S -scalarrepl | FileCheck %s
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
+target triple = "x86_64-apple-darwin11.0.1"
+
+; CHECK: test
+; CHECK-NOT: alloca
+
+define void @test() nounwind {
+entry:
+  %a156286 = alloca [4 x <4 x float>], align 16
+  br i1 undef, label %cif_done, label %for_test158.preheader
+
+for_test158.preheader:                            ; preds = %entry
+  %a156286305 = bitcast [4 x <4 x float>]* %a156286 to i8*
+  call void @llvm.memset.p0i8.i64(i8* %a156286305, i8 -1, i64 64, i32 16, i1 false)
+  unreachable
+
+cif_done:                                         ; preds = %entry
+  ret void
+}
+
+declare void @llvm.memset.p0i8.i64(i8* nocapture, i8, i64, i32, i1) nounwind