[llvm-commits] [PATCH] Allow the linker to link in functions that have not been materialized.

[Tanya Lattner]

Yes, sorry got my condition backwards. Modified patch. 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: linker-materialize2.patch
Type: application/octet-stream
Size: 932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111010/bb4c6c03/attachment.obj>
-------------- next part --------------


-Tanya

On Oct 10, 2011, at 5:48 PM, Eli Friedman wrote:

> On Mon, Oct 10, 2011 at 5:42 PM, Tanya Lattner <lattner at apple.com> wrote:
>> This change allows the functions in the source module to be materialized during the linking process.
>> 
>> If you have comments, please let me know.
> 
> +    // Skip if no body (function is external) or materialize.
> +    if (SF->isDeclaration()) {
> +      if (SF->isMaterializable()) {
> +        if (!SF->Materialize(&ErrorMsg))
> +          continue;
> 
> Shouldn't that be "return true;"?
> 
> -Eli