[llvm-commits] arm mc: fix relocation of an alias to an alias

[Ivan Krasin]

Hi llvm-team,

this patch is a noop for non-alias symbols (because Symbol.AliasedSymbol
returns Symbol itself, if it's not an alias) and it fixes a crash if the
symbol is alias (because section is null for aliases). That makes me
thinking that this falls under "obvious patch / fix the build" rule. I'm not
sure, though, since I'm still new to llvm project.

krasin

On Thu, Oct 6, 2011 at 1:12 PM, Ivan Krasin <krasin at google.com> wrote:

> Friendly ping. :)
>
> On Wed, Oct 5, 2011 at 5:33 PM, Ivan Krasin <krasin at chromium.org> wrote:
> > Hi llvm team!
> >
> > The patch attached fixes the problem that
> > ARMELFObjectWriter::ExplicitRelSym didn't resolve aliases.
> > For some reason, the single alias works just fine, but the alias to
> > alias crashes llc with the following message:
> >
> > llc: /usr/local/google/home/krasin/llvm/include/llvm/MC/MCSymbol.h:111:
> > const llvm::MCSection &llvm::MCSymbol::getSection() const: Assertion
> > `isInSection() && "Invalid accessor!"' failed.
> >
> > The full background of this issue is available here:
> > http://code.google.com/p/nativeclient/issues/detail?id=2340
> >
> > OK to commit?
> >
> > krasin
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111006/61c6d035/attachment.html>