[llvm-commits] [polly] r141212 - in /polly/trunk: utils/checkout_cloog.sh utils/get_cloog.sh www/get_started.html www/menu.html.incl

[Tobias Grosser]

Hi Sebastian,

thanks for reviewing.

On 10/06/2011 04:30 AM, Sebastian Pop wrote:
> On Wed, Oct 5, 2011 at 4:10 PM, Tobias Grosser
> <grosser at fim.uni-passau.de>  wrote:
>> Added: polly/trunk/utils/checkout_cloog.sh
>> URL: http://llvm.org/viewvc/llvm-project/polly/trunk/utils/checkout_cloog.sh?rev=141212&view=auto
>> ==============================================================================
>> --- polly/trunk/utils/checkout_cloog.sh (added)
>> +++ polly/trunk/utils/checkout_cloog.sh Wed Oct  5 16:10:10 2011
>> @@ -0,0 +1,86 @@
>> +#!/bin/sh
>> +
>> +CLOOG_HASH="cloog-0.16.3"
>> +ISL_HASH="cd1939ed06617d00159e8e51b72a804b467e98b4"
>> +
>> +check_command_line() {
>> +  if [ "${1}x" = "x" ] || [ "${2}x" != "x" ]
>
> To test that the number of parameters is exactly one, you may want to
> use:
>
>      if [ $# != 1 ]
Fixed.

>>
>> Modified: polly/trunk/www/get_started.html
>> URL: http://llvm.org/viewvc/llvm-project/polly/trunk/www/get_started.html?rev=141212&r1=141211&r2=141212&view=diff
>> ==============================================================================
>> --- polly/trunk/www/get_started.html (original)
>> +++ polly/trunk/www/get_started.html Wed Oct  5 16:10:10 2011
>> @@ -15,47 +15,69 @@
>>
>>   <h1>Getting Started: Building and Installing Polly</h1>
>>
>> +<h2 id="source">  Get the code</h2>
>> +
>> +The Polly source code is available in the LLVM SVN repository as well as in an
>> +official a git mirror. It is added to the<em>tools</em>
>
> s/official a git/official git/
>
>> +directory of the llvm sources.
>> +<b>Polly and LLVM need to be checked out at the time. Checkouts
>
> s/at the time/at the same time/
OK.

>
>> +Polly is tested and works with<a href="http://www.cloog.org">CLooG</a>  as of
>> +commit 225c2ed62fe37a4db22bf4b95c3731dab1a50dde
>> +and<a href="http://repo.or.cz/w/isl.git">isl</a>  as of
>> +commit cd1939ed06617d00159e8e51b72a804b467e98b4. To get and install the
>> +relevant cloog version use the following commands:
>
> I guess that you will forget to update the doc page at one point in
> time.  Why not pointing people to look at checkout_cloog.sh to get
> these sha keys?
You are right. I removed them here entirely and print them in 
checkout_cloog.sh. Interested users who do not want to run the script 
can lso find them at the top of the script source.

Thanks again for reviewing.

Tobi

P.S.: I also fixed some more bugs that blocked the buildbot.