[llvm-commits] [llvm] r141168 - /llvm/trunk/lib/Analysis/ScalarEvolution.cpp

[Andrew Trick]

Thanks for cleaning up. But broken? No, I just can't train myself to insert redundant parens in this idiom. GCC users will have to keep cleaning it up, or file a bug against gcc to silence a useless warning, or introduce proper assert macros in LLVM. 

Andy

On Oct 5, 2011, at 12:02 AM, Chandler Carruth <chandlerc at gmail.com> wrote:

> Author: chandlerc
> Date: Wed Oct  5 02:02:23 2011
> New Revision: 141168
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=141168&view=rev
> Log:
> Fix a broken assert found by -Wparentheses.
> 
> Modified:
>    llvm/trunk/lib/Analysis/ScalarEvolution.cpp
> 
> Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=141168&r1=141167&r2=141168&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)
> +++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Wed Oct  5 02:02:23 2011
> @@ -4714,7 +4714,7 @@
>     // If this operand is already visited, reuse the prior result.
>     P = PHIMap.lookup(OpInst);
>     if (P) {
> -      assert(!PHI || P == PHI && "inconsitent data flow");
> +      assert((!PHI || P == PHI) && "inconsitent data flow");
>       PHI = P;
>       continue;
>     }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits