[llvm-commits] [llvm] r139314 - in /llvm/trunk: include/llvm/Object/COFF.h include/llvm/Object/ObjectFile.h lib/Object/COFFObjectFile.cpp lib/Object/ELFObjectFile.cpp lib/Object/MachOObjectFile.cpp

[Benjamin Kramer]

On 04.10.2011, at 02:02, Michael Spencer wrote:

> On Thu, Sep 8, 2011 at 1:52 PM, Benjamin Kramer
> <benny.kra at googlemail.com> wrote:
>> Author: d0k
>> Date: Thu Sep  8 15:52:17 2011
>> New Revision: 139314
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=139314&view=rev
>> Log:
>> Add support for relocations to ObjectFile.
>> 
>> Patch by Danil Malyshev!
> 
> Is it alright with you if I change the relocation API to provide
> relocations per section instead of per object file? All currently
> supported file formats do this internally, and most tools access
> relocations in this manner. Also, your implementation of getAddress
> returns the memory address the relocation targets on the system as a
> uintptr_t, which seems very odd to me.

[Adding Danil, the original author of this patch]

Any change to this code is OK with me, this code currently has no users inside of
LLVM (and is somewhat untested). I don't know if Danil has any specific usecases
that require this design though.

- Ben