[llvm-commits] [patch] ThreeStageLoopUnroll

[Daniel Nicácio]

Thanks for the reply guys, I will fix what you pointed out. And I will work
on it to improve it further.



On Tue, Sep 27, 2011 at 2:55 PM, Devang Patel <dpatel at apple.com> wrote:

>
> On Sep 27, 2011, at 2:48 PM, David Blaikie wrote:
>
> 2) General llvm convention is to avoid
>>
>> +  bool candidate = L->isThreeStageUnrollCandidate(L, LI);
>> +  if(candidate) {
>> ….
>>
>> and do
>>
>> +  if (bool candidate = … ) {
>> +  }
>>
>> if candidate is not used outside "if".
>>
>
> At that point you might as well just write:
>
> if (L->isThreeStageUnrollCandidate(L, LI)) {
> }
>
>
> Yes, if candidate is not used inside "if".
> -
> Devang
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111003/7dcab735/attachment.html>