[llvm-commits] [llvm] r140951 - in /llvm/trunk: ./ include/llvm/TableGen/ lib/ lib/TableGen/ utils/TableGen/

[Chris Lattner]

On Oct 1, 2011, at 9:41 AM, Peter Collingbourne wrote:

> Author: pcc
> Date: Sat Oct  1 11:41:13 2011
> New Revision: 140951
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=140951&view=rev
> Log:
> Move TableGen's parser and entry point into a library
> 
> This is the first step towards splitting LLVM and Clang's tblgen executables.

Hi Peter,

Thanks for working on this.  Doing this right is going to require some work though:

1. All of the 'main' code and the top-level cl::opt's should be in utils/tablegen, not in TableGen/Main.h
2. The tablegen headers (like the rest of it :) are a mess, they are not split properly between public and private headers.
3. The tblgen code uses RTTI and EH, which none of the rest of the LLVM libraries do.

So long as RTTI and EH don't invade tools other than the utils/TableGen executable, I'm ok with continuing to forget about #3, but #1 and #2 are pretty important.

Are you committed to fixing these problems as follow-ons?  What direction are you going here?

-Chris