[llvm-commits] fixing the OCaml bindings for 3.0

[Cameron Zwarich]

On Oct 2, 2011, at 9:08 AM, Török Edwin wrote:

> On 10/01/2011 03:14 PM, Török Edwin wrote:
>> Hi,
>> 
>> I noticed that currently the OCaml bindings don't pass the testsuite.
>> First problem is due to exception handling changes: invoke must point to a basic block with a landingpad,
>> otherwise verifier rejects it.
>> 
>> Attach patch tries to address that by exposing LLVMBuildLandingPad, and calling it: the verifier passes now.
>> There are still many grep failures left though, I'll probably go through these in the next days and try to figure what is wrong.
>> 
>> Some help would be appreciated, there are currently 158 grep failures (even after applying this patch), see log.gz.
> 
> Looks like I misinterpreted the output from lit: it shows all greps regardless if they failed or not.
> There was really only one failure, attached patch makes all Bindings/Ocaml tests pass!
> 
> OK to commit?

I don't have experience with the Ocaml bindings, but it looks good to me.

Cameron