[llvm-commits] [PATCH] Win64 Support for Crash Stack Crawls
Michael Spencer
bigcheesegs at gmail.com
Fri Sep 30 17:08:30 PDT 2011
On Wed, Sep 21, 2011 at 4:06 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> This patch fixes a FIXME in Signals.inc for Win64. Now, it contains
> support for 32- and 64-bit versions of the library. The StackWalk64
> API (and friends) were introduced in DebugHlp 5.1, which shipped with
> Windows XP. However, I don't have an XP install handy to test
> against, so I've not verified on the LCD platform. However, I have
> tested it on Win7 64-bit with 32-bit and 64-bit versions of the
> library.
>
> The majority of this patch involved working around MinGW. :-( It
> doesn't have support for any of the 64-bit APIs or structures, so I
> had to dynamically load them. All structures and function signatures
> were pulled from the platform SDK. So this has been tested with VC++
> and MinGW both.
>
> ~Aaron
It looks good in general, although I have not been able to test
anything other than Windows 7 x64 with VC++ 32bit llvm. The only
suggestion I have is to remove the trailing whitespace.
Committed as r140906 (with trailing whitespace removed).
- Michael Spencer
More information about the llvm-commits
mailing list