[llvm-commits] [llvm] r140712 - in /llvm/trunk/tools: Makefile llvm-cov/ llvm-cov/CMakeLists.txt llvm-cov/GCOVReader.cpp llvm-cov/GCOVReader.h llvm-cov/Makefile llvm-cov/llvm-cov.cpp

[Devang Patel]

On Sep 29, 2011, at 10:55 AM, Nick Lewycky wrote:

> On 29 September 2011 10:13, Devang Patel <dpatel at apple.com> wrote:
>> Hi Nick,
>> 
>> On Sep 28, 2011, at 6:01 PM, Nick Lewycky wrote:
>> 
>>> On 28 September 2011 11:50, Devang Patel <dpatel at apple.com> wrote:
>>>> Author: dpatel
>>>> Date: Wed Sep 28 13:50:00 2011
>>>> New Revision: 140712
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=140712&view=rev
>>>> Log:
>>>> Introduce llvm-cov.
>>> 
>>> Cool!!
>>> 
>>> At a high-level, is there any interest in creating a GCOV data storage
>>> for reading/manipulating/writing? I didn't think anyone would ever
>>> need to write llvm-cov, so I decided to make GCOVProfiling write-only,
>>> but you have types with the same name here.
>> 
>> Types could be refactored into a common header.
> 
> You don't sound enthusiastic :) I'm happy to leave it as two separate
> pieces if there's no use-case for joining them.

I am not inclined to do it myself but feel free to refactor it appropriately.
-
Devang