[llvm-commits] [llvm] r140789 - /llvm/trunk/tools/llvm-cov/GCOVReader.cpp

[Devang Patel]

Author: dpatel
Date: Thu Sep 29 12:06:40 2011
New Revision: 140789

URL: http://llvm.org/viewvc/llvm-project?rev=140789&view=rev
Log:
Simplify.

Modified:
    llvm/trunk/tools/llvm-cov/GCOVReader.cpp

Modified: llvm/trunk/tools/llvm-cov/GCOVReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/GCOVReader.cpp?rev=140789&r1=140788&r2=140789&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/GCOVReader.cpp (original)
+++ llvm/trunk/tools/llvm-cov/GCOVReader.cpp Thu Sep 29 12:06:40 2011
@@ -27,6 +27,16 @@
   DeleteContainerPointers(Functions);
 }
 
+/// isGCDAFile - Return true if Format identifies a .gcda file.
+static bool isGCDAFile(GCOVFormat Format) {
+  return Format == GCDA_402 || Format == GCDA_404;
+}
+
+/// isGCNOFile - Return true if Format identifies a .gcno file.
+static bool isGCNOFile(GCOVFormat Format) {
+  return Format == GCNO_402 || Format == GCNO_404;
+}
+
 /// read - Read GCOV buffer.
 bool GCOVFile::read(GCOVBuffer &Buffer) {
   GCOVFormat Format = Buffer.readGCOVFormat();
@@ -36,20 +46,16 @@
   unsigned i = 0;
   while (1) {
     GCOVFunction *GFun = NULL;
-    if (Format == GCDA_402 || Format == GCDA_404) {
-      if (i < Functions.size())
-	GFun = Functions[i];
-    } else
+    if (isGCDAFile(Format)) {
+      // Use existing function while reading .gcda file.
+      assert (i < Functions.size() && ".gcda data does not match .gcno data");
+      GFun = Functions[i];
+    } else if (isGCNOFile(Format)){
       GFun = new GCOVFunction();
-
-    if (GFun && GFun->read(Buffer, Format)) {
-      if (Format == GCNO_402 || Format == GCNO_404) 
-	Functions.push_back(GFun);
+      Functions.push_back(GFun);
     }
-    else {
-      delete GFun;
+    if (!GFun || !GFun->read(Buffer, Format))
       break;
-    }
     ++i;
   }
   return true;