[llvm-commits] [llvm] r140616 - in /llvm/trunk/lib/Target/PTX: PTXAsmPrinter.cpp PTXISelDAGToDAG.cpp PTXISelLowering.cpp PTXInstrLoadStore.td PTXMachineFunctionInfo.h PTXRegisterInfo.cpp

[Benjamin Kramer]

On 27.09.2011, at 17:12, NAKAMURA Takumi wrote:

> lJustin,
> 
>> +      std::string ParamName = PM.getParamName(Param);
>> +      SDValue ParamValue = DAG.getTargetExternalSymbol(ParamName.c_str(),
>> +                                                       MVT::Other);
> 
> ParamName.c_str() might be escaped, I guess.
> It causes undefined behavior on msvc.
> 
> As dirty hack, to tweak them (4 points) as strdup(ParamName.c_str()),
> it could be suppressed.

Fixed (without dirty hacks) in r140679.

- Ben