[llvm-commits] [llvm] r140539 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp test/DebugInfo/2011-09-26-GlobalVarContext.ll

[James Molloy]

Heh, Thanks Eric, as long as I'm not being judged for landing broken commits :)

All this might just give me enough clout with management to get myself a nice brutish iMac, excellent! ;)

Cheers,

James
________________________________________
From: Eric Christopher [echristo at apple.com]
Sent: 26 September 2011 21:08
To: Jakob Stoklund Olesen
Cc: James Molloy; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r140539 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp test/DebugInfo/2011-09-26-GlobalVarContext.ll

On Sep 26, 2011, at 1:07 PM, Jakob Stoklund Olesen wrote:

>
> On Sep 26, 2011, at 1:04 PM, Eric Christopher wrote:
>
>>
>> On Sep 26, 2011, at 12:36 PM, James Molloy wrote:
>>
>>> Hi Jakob,
>>>
>>> I thought I needed one, but after discussion with Devang and Eric I was convinced it was fine to remove it!
>>>
>>
>> I saw that too and laughed. Sorry about that.
>>
>> In general you can make them independent, you may just have to be clever about how you write the matching.
>
> In fact, no triple and clever matching gives you better test coverage.
>
> Most people chicken out and add a triple, though.

Heh. That was why we were trying to get James not to do so :)

-eric



-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.