[llvm-commits] [llvm] r140539 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp test/DebugInfo/2011-09-26-GlobalVarContext.ll

[James Molloy]

Hi,

Strike that, I see Eli already committed a fix. Apologies to any concerned - I hadn't thought the asm output would be different on Darwin!

Cheers,

James
________________________________________
From: James Molloy
Sent: 26 September 2011 20:36
To: Jakob Stoklund Olesen
Cc: llvm-commits at cs.uiuc.edu
Subject: RE: [llvm-commits] [llvm] r140539 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp test/DebugInfo/2011-09-26-GlobalVarContext.ll

Hi Jakob,

I thought I needed one, but after discussion with Devang and Eric I was convinced it was fine to remove it!

I'll re-add it immediately.

Thanks for bringing this to my attention. Out of interest, what platform are you running on where it managed to fail?

Cheers,

James
________________________________________
From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Jakob Stoklund Olesen [stoklund at 2pi.dk]
Sent: 26 September 2011 19:21
To: James Molloy
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r140539 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp test/DebugInfo/2011-09-26-GlobalVarContext.ll

On Sep 26, 2011, at 10:40 AM, James Molloy wrote:

> Author: jamesm
> Date: Mon Sep 26 12:40:42 2011
> New Revision: 140539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=140539&view=rev
> Log:
> Fix emission of debug data for global variables. getContext() on DIGlobalVariables is not valid any more.

Hi James.

Please make sure your test case is platform agnostic.

******************** TEST 'LLVM :: DebugInfo/2011-09-26-GlobalVarContext.ll' FAILED ********************Script:
Command Output (stderr):
--
test/DebugInfo/2011-09-26-GlobalVarContext.ll:41:10: error: expected string not found in input
; CHECK: .ascii "GLOBAL" # DW_AT_name
         ^
<stdin>:1:2: note: scanning from here
 .section __TEXT,__text,regular,pure_instructions
 ^
<stdin>:75:2: note: possible intended match here
 .ascii "GLOBAL" ## DW_AT_name
 ^
--


You can for example add a triple argument.

/jakob

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.