[llvm-commits] [llvm] r140296 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Evan Cheng]

On Sep 22, 2011, at 8:38 AM, Eli Friedman wrote:

> On Thu, Sep 22, 2011 at 1:19 AM, Duncan Sands <baldrick at free.fr> wrote:
>>> The SSE version differences for fmin/fmax are more involved than I thought.
>> 
>> While on the subject of fmin/fmax, I noticed that "isCommutable" is set to
>> zero for max/min.  Yet the result of max/min presumably doesn't depend on
>> the order of its arguments, so is this a mistake?
> 
> Strictly spearking, min/max on x86 are not commutable.  It would
> probably be okay to commute them when -ffast-math is turned on,
> though.

Right, it's a bug that I know about but haven't gotten to. Unfortunately we'd like to continue to support the -ffast-math optimization so I haven't simply remove the isCommutable = 1 bit. Patches welcome. :-)

Evan

> 
> -Eli
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits