[llvm-commits] [llvm] r140316 - /llvm/trunk/lib/Target/Mips/MipsMCSymbolRefExpr.cpp

[Bruno Cardoso Lopes]

Hi Akira,

On Thu, Sep 22, 2011 at 11:17 AM, Akira Hatanaka <ahatanak at gmail.com> wrote:
> I am not opposed to making this change, but is this needed to conform
> to LLVM's calling convention? I do see several places (not in Mips's
> directory, but in other targets) in which if statement is contained in
> one line. Is this a bad coding style?

In some cases I wouldn't care at all, but look below:

>>> -  if (Kind != VK_Mips_None)
>>> -    OS << ')';
>>> +  if (Kind == VK_Mips_GPOFF_HI || Kind == VK_Mips_GPOFF_LO) OS << ")))";
>>> +  else if (Kind != VK_Mips_None)                            OS << ')';
>>>  }

It's messy (the first is bloated and the second has a weird amount of
spaces...), please fix it!

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc