[llvm-commits] [llvm] r140278 - /llvm/trunk/tools/llvm-objdump/MachODump.cpp

[Benjamin Kramer]

Author: d0k
Date: Wed Sep 21 17:16:43 2011
New Revision: 140278

URL: http://llvm.org/viewvc/llvm-project?rev=140278&view=rev
Log:
llvm-objdump: Detach symbol listing from section enumeration for mach-o.

This reduces memory usage as we don't add the same symbol multiple times anymore.

Modified:
    llvm/trunk/tools/llvm-objdump/MachODump.cpp

Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=140278&r1=140277&r2=140278&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Wed Sep 21 17:16:43 2011
@@ -230,15 +230,6 @@
         MachOObj->ReadSection(LCI, SectNum, Sect);
         Sections.push_back(copySection(Sect));
 
-        // Store the symbols in this section.
-        if (SymtabLC) {
-          for (unsigned i = 0; i != (*SymtabLC)->NumSymbolTableEntries; ++i) {
-            InMemoryStruct<macho::SymbolTableEntry> STE;
-            MachOObj->ReadSymbolTableEntry((*SymtabLC)->SymbolTableOffset, i,
-                                           STE);
-            Symbols.push_back(copySymbol(STE));
-          }
-        }
       }
     } else if (LCI.Command.Type == macho::LCT_Segment64) {
       InMemoryStruct<macho::Segment64LoadCommand> Segment64LC;
@@ -250,16 +241,6 @@
         InMemoryStruct<macho::Section64> Sect64;
         MachOObj->ReadSection64(LCI, SectNum, Sect64);
         Sections.push_back(copySection(Sect64));
-
-        // Store the symbols in this section.
-        if (SymtabLC) {
-          for (unsigned i = 0; i != (*SymtabLC)->NumSymbolTableEntries; ++i) {
-            InMemoryStruct<macho::Symbol64TableEntry> STE;
-            MachOObj->ReadSymbol64TableEntry((*SymtabLC)->SymbolTableOffset, i,
-                                             STE);
-            Symbols.push_back(copySymbol(STE));
-          }
-        }
       }
     } else if (LCI.Command.Type == macho::LCT_FunctionStarts) {
       // We found a function starts segment, parse the addresses for later
@@ -270,6 +251,22 @@
       MachOObj->ReadULEB128s(LLC->DataOffset, FoundFns);
     }
   }
+  // Store the symbols.
+  if (SymtabLC) {
+    for (unsigned i = 0; i != (*SymtabLC)->NumSymbolTableEntries; ++i) {
+      if (MachOObj->is64Bit()) {
+        InMemoryStruct<macho::Symbol64TableEntry> STE;
+        MachOObj->ReadSymbol64TableEntry((*SymtabLC)->SymbolTableOffset, i,
+                                         STE);
+        Symbols.push_back(copySymbol(STE));
+      } else {
+        InMemoryStruct<macho::SymbolTableEntry> STE;
+        MachOObj->ReadSymbolTableEntry((*SymtabLC)->SymbolTableOffset, i,
+                                       STE);
+        Symbols.push_back(copySymbol(STE));
+      }
+    }
+  }
 }
 
 void llvm::DisassembleInputMachO(StringRef Filename) {