[llvm-commits] [llvm] r140234 - in /llvm/trunk/lib: Support/ConstantRange.cpp Target/CppBackend/CPPBackend.cpp Target/X86/X86ISelLowering.cpp VMCore/Constants.cpp VMCore/Instructions.cpp

[Richard Trieu]

On Tue, Sep 20, 2011 at 8:27 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Change:
>>
>>  assert(!"error message");
>>
>> To:
>>
>>  assert(0 && "error message");
>
> Should these all be changed to llvm_unreachable instead?
> - David

I'm not sure what's the difference between assert's and
llvm_unreachable's and how they are used within LLVM.  This code
change is to prepare the codebase for a new warning that I hope to
turn on soon in Clang.  Thus the change preserves behavior with
minimal changes to not prevent the warning.