[llvm-commits] [llvm] r140178 - in /llvm/trunk/lib/Target/Mips: Mips.td MipsSubtarget.h

[Bruno Cardoso Lopes]

Hi Akira,

>   bool isMips32() const { return MipsArchVersion >= Mips32; }
> -  bool isMips32r2() const { return MipsArchVersion == Mips32r2; }
> +  bool isMips32r2() const { return MipsArchVersion == Mips32r2 ||
> +                                   MipsArchVersion == Mips64r2; }

This seems a bit confusing, probably not the way to go. I think
isMips32r2() should answer only for Mips32r2, if you want to check
both, have a predicate like "isMipsRev2". Why you want isMips32r2() to
answer for both?

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc