[llvm-commits] [PATCH] Removed FIXME from Memory.inc on Windows

Aaron Ballman aaron at aaronballman.com
Mon Sep 19 15:30:53 PDT 2011


On Mon, Sep 19, 2011 at 4:31 AM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hi Aaron,
>
>> This patch addresses a FIXME in the Memory class on Windows.  It now
>> supports allocating blocks of memory around the "NearBlock" parameter.
>>  Additionally, it adds support for changing the protection for blocks
>> of virtual memory.
> Stuff looks generally ok for me, but I'd ask Takumi as well.
> Also, please split the patch into 2 parts, it definitely contains 2
> unrelated blocks
>
> Thanks for working on this!

My pleasure!  I've split the changes into two separate diffs, and
attached them both.

VProt.diff is the patch for supporting setting memory to be writable
or executable.

NearBlock.diff is the patch which removes the FIXME for NearBlock support.

Thanks!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VProt.diff
Type: application/octet-stream
Size: 1961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110919/e6ee0cdd/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NearBlock.diff
Type: application/octet-stream
Size: 950 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110919/e6ee0cdd/attachment-0001.obj>


More information about the llvm-commits mailing list