[llvm-commits] Small fix to fs::create_directories()

Albert Wong (王重傑) ajwong at google.com
Fri Sep 16 11:41:36 PDT 2011


Thanks!

On Fri, Sep 16, 2011 at 11:38 AM, Eli Friedman <eli.friedman at gmail.com>wrote:

> On Fri, Sep 16, 2011 at 11:24 AM, Albert Wong (王重傑) <ajwong at google.com>
> wrote:
> > If you could commit it, that'd be great.  I'm not a project committer. :)
>
> r139928.
>
> -Eli
>
> > -Albert
> >
> > On Fri, Sep 16, 2011 at 11:23 AM, Eli Friedman <eli.friedman at gmail.com>
> > wrote:
> >>
> >> On Thu, Sep 15, 2011 at 7:00 PM, Albert Wong (王重傑) <ajwong at google.com>
> >> wrote:
> >> > Hey all,
> >> > I found a small bug in PathV2's implementation of
> create_directories().
> >> >  If
> >> > you try to call it with a path like /some/new/path, it will only
> create
> >> > the
> >> > first non-existent directory due to an improper early return.
> >> > I've attached a patch with a fix.  I also file a bug for it here:
> >> >   http://llvm.org/bugs/show_bug.cgi?id=10940
> >> > Let me know if there are any questions.
> >>
> >> Patch looks fine.  (Not sure if you need me to commit this for you.)
> >>
> >> -Eli
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110916/4bcb63a8/attachment.html>


More information about the llvm-commits mailing list