[llvm-commits] [llvm] r139776 - in /llvm/trunk/lib/DebugInfo: DWARFDebugLine.cpp DWARFDebugLine.h

Nick Lewycky nicholas at mxc.ca
Wed Sep 14 20:41:52 PDT 2011


Author: nicholas
Date: Wed Sep 14 22:41:51 2011
New Revision: 139776

URL: http://llvm.org/viewvc/llvm-project?rev=139776&view=rev
Log:
Give structs with virtual methods a virtual destructor.

Modified:
    llvm/trunk/lib/DebugInfo/DWARFDebugLine.cpp
    llvm/trunk/lib/DebugInfo/DWARFDebugLine.h

Modified: llvm/trunk/lib/DebugInfo/DWARFDebugLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugLine.cpp?rev=139776&r1=139775&r2=139776&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARFDebugLine.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARFDebugLine.cpp Wed Sep 14 22:41:51 2011
@@ -91,6 +91,8 @@
   }
 }
 
+DWARFDebugLine::State::~State() {}
+
 void DWARFDebugLine::State::appendRowToMatrix(uint32_t offset) {
   ++row;  // Increase the row number.
   LineTable::appendRow(*this);
@@ -117,6 +119,8 @@
   }
 }
 
+DWARFDebugLine::DumpingState::~DumpingState() {}
+
 void DWARFDebugLine::DumpingState::finalize(uint32_t offset) {
   LineTable::dump(OS);
 }

Modified: llvm/trunk/lib/DebugInfo/DWARFDebugLine.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugLine.h?rev=139776&r1=139775&r2=139776&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARFDebugLine.h (original)
+++ llvm/trunk/lib/DebugInfo/DWARFDebugLine.h Wed Sep 14 22:41:51 2011
@@ -148,6 +148,7 @@
     };
 
     State() : row(0) {}
+    virtual ~State();
 
     virtual void appendRowToMatrix(uint32_t offset);
     virtual void finalize(uint32_t offset) { row = DoneParsingLineTable; }
@@ -160,6 +161,7 @@
 
   struct DumpingState : public State {
     DumpingState(raw_ostream &OS) : OS(OS) {}
+    virtual ~DumpingState();
     virtual void finalize(uint32_t offset);
   private:
     raw_ostream &OS;





More information about the llvm-commits mailing list