[llvm-commits] [llvm] r139340 - /llvm/trunk/tools/gold/gold-plugin.cpp

[Ivan Krasin]

Hi Rafael,

I'm sorry for the inconvenience: this patch has been obsoleted by
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20110912/127817.html
and I have forgot to claim that in this thread.

ToT gold plugin has already received the proper fix (r139544 -
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20110912/127826.html).
It fixes not only the old Gold, but also ar/nm plugins which don't
provide get_view as well).

Please, let me know if you have any objections about that CL.

krasin

On Wed, Sep 14, 2011 at 10:10 AM, Rafael Ávila de Espíndola
<rafael.espindola at gmail.com> wrote:
>> Please, find the patch attached. It makes the diagnostics more precise
>> and adds a fast path for skipping non-bitcode files, if Gold version
>> supports get_view (i.e. gold is more-or-less recent). The latter is
>> important for two reasons:
>>
>> - it's the common case for linking with the Gold plugin. It's good to
>> avoid creating heavy-weight Bitcode reader.
>> - after the change that has enabled these diagnostic messages, the
>> users have started to see warnings like "bfd plugin: Failed to create
>> LTO module: Invalid bitcode signature" which is definitely not
>> desirable.
>
> It would still print the warning with "old" versions of gold, no? Can
> you fix that too?
>
> Alternatively, is that in some released version of gold already? If so
> you can probably just drop the if and assume we have a sufficiently
> recent gold.
>
>> OK to commit?
>
> OK with one of those changes.
>
>> krasin
>
> Thanks!
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>