[llvm-commits] [llvm] r139340 - /llvm/trunk/tools/gold/gold-plugin.cpp

Duncan Sands baldrick at free.fr
Thu Sep 8 23:14:34 PDT 2011


Hi Ivan,

> -  if (!M)
> +  if (!M) {
> +    if (const char* msg = lto_get_error_message()) {
> +      (*message)(LDPL_ERROR, "Failed to create LTO module: %s", msg);

maybe this should mention LLVM?  If you are doing GCC and LLVM LTO at the
same time, just mentioning LTO is ambiguous.  But perhaps the name of the
plugin is printed, and that makes it clear?

Ciao, Duncan.

> +      return LDPS_ERR;
> +    }
>       return LDPS_OK;
> +  }
>
>     *claimed = 1;
>     Modules.resize(Modules.size() + 1);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list