[llvm-commits] [PATCH]lto/addAsmGlobalSymbols: fail fracefully when the target does not define AsmParser

[Ivan Krasin]

Thanks, r139283.

On Thu, Sep 8, 2011 at 12:34 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Thu, Sep 8, 2011 at 12:13 AM, Ivan Krasin <krasin at chromium.org> wrote:
>> On Wed, Sep 7, 2011 at 5:51 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>>> On Wed, Sep 7, 2011 at 5:42 PM, Ivan Krasin <krasin at chromium.org> wrote:
>>>> Hi llvm team,
>>>>
>>>> this patch makes LTO fail gracefully if the target does not define
>>>> AsmParser instead of aborting on null pointer.
>>>>
>>>> Please, find the patch attached or online:
>>>> http://codereview.chromium.org/7847007/
>>>>
>>>> OK to commit?
>>>
>>> What exactly does the error output look like with this patch?  I'm
>>> guessing it isn't that informative if you aren't setting errMsg...
>> Thanks, Eli, it's a good comment. Could you please take a look at it now?
>
> Looks fine.
>
>> Note: it appears that gold-plugin does not use lto_get_error_message
>> at all, so this assigned message will be unused in gold-plugin (but
>> will be used in other proper clients of tools/lto).
>> Should I fix gold plugin as well (as a separate patch)?
>
> That would be nice.
>
> -Eli
>