[llvm-commits] [PATCH]lto/addAsmGlobalSymbols: fail fracefully when the target does not define AsmParser

[Ivan Krasin]

On Wed, Sep 7, 2011 at 5:51 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Wed, Sep 7, 2011 at 5:42 PM, Ivan Krasin <krasin at chromium.org> wrote:
>> Hi llvm team,
>>
>> this patch makes LTO fail gracefully if the target does not define
>> AsmParser instead of aborting on null pointer.
>>
>> Please, find the patch attached or online:
>> http://codereview.chromium.org/7847007/
>>
>> OK to commit?
>
> What exactly does the error output look like with this patch?  I'm
> guessing it isn't that informative if you aren't setting errMsg...
Thanks, Eli, it's a good comment. Could you please take a look at it now?

Note: it appears that gold-plugin does not use lto_get_error_message
at all, so this assigned message will be unused in gold-plugin (but
will be used in other proper clients of tools/lto).
Should I fix gold plugin as well (as a separate patch)?

krasin
>
> -Eli
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lto_fail_msg.diff
Type: text/x-patch
Size: 3072 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110908/06dce2f0/attachment.bin>