[llvm-commits] Patch to add support for WidenVecRes_MERGE_VALUES

[Villmow, Micah]

> -----Original Message-----
> From: Eli Friedman [mailto:eli.friedman at gmail.com]
> Sent: Friday, August 26, 2011 7:03 PM
> To: Villmow, Micah
> Cc: llvm-commits
> Subject: Re: [llvm-commits] Patch to add support for
> WidenVecRes_MERGE_VALUES
> 
> On Fri, Aug 26, 2011 at 6:34 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > This is a patch to fix LLVM bug10736 which occurs with our AMDIL
> backend.
> > I've also added a test case, but since the AMDIL backend isn't in the
> tree yet, I don't know how much good it will do.
> > Please review.
> 
> It looks correct, but it doesn't seem very general... there should
> really just be a generic DecomposeMERGE_VALUES usable from every
> handler that just has a single "ReplaceValueWith(SDValue(N, i),
> SDValue(N->getOperand(i)));" loop.  (Long-term, we really should just
> get rid of MERGE_VALUES, but it's a substantial amount of work.)
> 
[Villmow, Micah] Yeah, I pretty much copied it from the SplitRes_MERGE_VALUES node, but I wasn't sure if this was the correct approach. I'll look into cleaning this up and submit a newer patch later this week.
> -Eli