[llvm-commits] [llvm] r138660 - in /llvm/trunk: lib/Target/X86/X86.td lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrCompiler.td lib/Target/X86/X86InstrInfo.td lib/Target/X86/X86Subtarget.cpp lib/Target/X86/X86Subtarget.h test/CodeGen/X86/cmpxchg16b.ll

[Eric Christopher]

On Aug 26, 2011, at 2:21 PM, Eli Friedman wrote:

> +def FeatureCMPXCHG16B : SubtargetFeature<"cmpxchg16b", "HasCmpxchg16b", "true",
> +                                      "64-bit with cmpxchg16b",
> +                                      [Feature64Bit]>;

This seems rather convoluted - or at least I'm not sure why you'd want to hide Feature64Bit inside of the cmpxchg check.

Otherwise it looks good. :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110826/e202ad46/attachment.html>