[llvm-commits] [llvm] r138163 - in /llvm/trunk: lib/Target/ARM/ARMBaseInstrInfo.cpp lib/Target/ARM/ARMExpandPseudoInsts.cpp test/CodeGen/ARM/2011-08-12-vmovqqqq-pseudo.ll

[Jakob Stoklund Olesen]

On Wed, August 24, 2011 2:44 am, Evan Cheng wrote:
> I could have sworn there is a good reason for the pseudo-instruction. Can
> this change inhibit some optimization, e.g. coalescing, copy propagation?

I think this was true before we started using the generic COPY instruction
during register allocation.

Now they are not needed any more.

/jakob

> On Aug 19, 2011, at 5:32 PM, Jakob Stoklund Olesen wrote:
>
>>
>> On Aug 19, 2011, at 5:17 PM, Chad Rosier wrote:
>>
>>> Author: mcrosier
>>> Date: Fri Aug 19 19:17:25 2011
>>> New Revision: 138163
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=138163&view=rev
>>> Log:
>>> VMOVQQQQs pseudo instructions are only created by
>>> ARMBaseInstrInfo::copyPhysReg.
>>> Therefore, rather then generate a pseudo instruction, which is later
>>> expanded,
>>> generate the necessary instructions in place.
>>
>> Nice!
>>
>> Does that mean the VMOVQQQQ pseudo-instruction can be deleted completely
>> now?
>>
>> You can probably do the same trick with VMOVQQ.
>>
>> /jakob
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>