[llvm-commits] [llvm] r138287 - in /llvm/trunk: lib/Target/ARM/AsmParser/ARMAsmParser.cpp test/MC/ARM/thumb-diagnostics.s

[Jim Grosbach]

Author: grosbach
Date: Mon Aug 22 18:01:07 2011
New Revision: 138287

URL: http://llvm.org/viewvc/llvm-project?rev=138287&view=rev
Log:
Thumb assemmbly parsing diagnostic improvements for LDM.

Modified:
    llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
    llvm/trunk/test/MC/ARM/thumb-diagnostics.s

Modified: llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp?rev=138287&r1=138286&r2=138287&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp Mon Aug 22 18:01:07 2011
@@ -3084,6 +3084,9 @@
     // Thumb LDM instructions are writeback iff the base register is not
     // in the register list.
     unsigned Rn = Inst.getOperand(0).getReg();
+    bool hasWritebackToken =
+      (static_cast<ARMOperand*>(Operands[3])->isToken() &&
+       static_cast<ARMOperand*>(Operands[3])->getToken() == "!");
     bool doesWriteback = true;
     for (unsigned i = 3; i < Inst.getNumOperands(); ++i) {
       unsigned Reg = Inst.getOperand(i).getReg();
@@ -3091,15 +3094,18 @@
         doesWriteback = false;
       // Anything other than a low register isn't legal here.
       if (!isARMLowRegister(Reg))
-        return Error(Operands[4]->getStartLoc(),
+        return Error(Operands[3 + hasWritebackToken]->getStartLoc(),
                      "registers must be in range r0-r7");
     }
     // If we should have writeback, then there should be a '!' token.
-    if (doesWriteback &&
-        (!static_cast<ARMOperand*>(Operands[3])->isToken() ||
-         static_cast<ARMOperand*>(Operands[3])->getToken() != "!"))
+    if (doesWriteback && !hasWritebackToken)
       return Error(Operands[2]->getStartLoc(),
                    "writeback operator '!' expected");
+    // Likewise, if we should not have writeback, there must not be a '!'
+    if (!doesWriteback && hasWritebackToken)
+      return Error(Operands[3]->getStartLoc(),
+                   "writeback operator '!' not allowed when base register "
+                   "in register list");
 
     break;
   }

Modified: llvm/trunk/test/MC/ARM/thumb-diagnostics.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/thumb-diagnostics.s?rev=138287&r1=138286&r2=138287&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/thumb-diagnostics.s (original)
+++ llvm/trunk/test/MC/ARM/thumb-diagnostics.s Mon Aug 22 18:01:07 2011
@@ -45,12 +45,16 @@
 @ Invalid writeback and register lists for LDM
         ldm r2!, {r5, r8}
         ldm r2, {r5, r7}
+        ldm r2!, {r2, r3, r4}
 @ CHECK-ERRORS: error: registers must be in range r0-r7
 @ CHECK-ERRORS:         ldm r2!, {r5, r8}
 @ CHECK-ERRORS:                  ^
 @ CHECK-ERRORS: error: writeback operator '!' expected
 @ CHECK-ERRORS:         ldm r2, {r5, r7}
 @ CHECK-ERRORS:             ^
+@ CHECK-ERRORS: error: writeback operator '!' not allowed when base register in register list
+@ CHECK-ERRORS:         ldm r2!, {r2, r3}
+@ CHECK-ERRORS:               ^
 
 
 @ Out of range immediates for LSL instruction.