[llvm-commits] [Patch] PathV2 on Windows

[Benjamin Kramer]

On 20.08.2011, at 13:03, Aaron Ballman wrote:

> This patch corrects the FIXME about not handling enough reserved
> filenames in PathV2.inc on Windows.  It used to only support the nul
> device path, but now supports the complete documented list from
> Microsoft.

Some nits:
- Don't use a SmallPtrSet when you don't need fast lookup. A const char* array is sufficient here, and you can use the {}-initializer syntax.
- Make helper functions "static" and make sure to use the same amount of whitespace as the rest of the code.

Otherwise looks good, thank you for working on this.

- Ben