[llvm-commits] [llvm] r138116 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb.td test/CodeGen/ARM/avoid-cpsr-rmw.ll test/CodeGen/Thumb2/thumb2-mls.ll test/CodeGen/Thumb2/thumb2-mul.ll

[Jim Grosbach]

On Aug 19, 2011, at 4:01 PM, Jakob Stoklund Olesen wrote:

> 
> On Aug 19, 2011, at 3:19 PM, Jim Grosbach wrote:
> 
>> --- llvm/trunk/test/CodeGen/ARM/avoid-cpsr-rmw.ll (original)
>> +++ llvm/trunk/test/CodeGen/ARM/avoid-cpsr-rmw.ll Fri Aug 19 17:19:48 2011
>> @@ -6,9 +6,9 @@
>> define i32 @t(i32 %a, i32 %b, i32 %c, i32 %d) nounwind readnone {
>> entry:
>> ; CHECK: t:
>> -; CHECK: muls r2, r3, r2
>> +; CHECK: muls r2, r2, r3
>> ; CHECK-NEXT: mul  r0, r0, r1
>> -; CHECK-NEXT: muls r0, r2, r0
>> +; CHECK-NEXT: muls r0, r0, r2
>>  %0 = mul nsw i32 %a, %b
>>  %1 = mul nsw i32 %c, %d
>>  %2 = mul nsw i32 %0, %1
> 
> I don't think the temporaries are required to use r2 and r0 here. Please use FileCheck variables instead.


Not my test, so I didn't even look at that part. You're probably right. I'll see about cleaning that up while I'm poking around in there anyway.

-Jim