[llvm-commits] [llvm] r138042 - /llvm/trunk/lib/Target/ARM/ARMInstrThumb.td

Jim Grosbach grosbach at apple.com
Fri Aug 19 09:52:32 PDT 2011


Author: grosbach
Date: Fri Aug 19 11:52:32 2011
New Revision: 138042

URL: http://llvm.org/viewvc/llvm-project?rev=138042&view=rev
Log:
Add explanatory comment.

Modified:
    llvm/trunk/lib/Target/ARM/ARMInstrThumb.td

Modified: llvm/trunk/lib/Target/ARM/ARMInstrThumb.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMInstrThumb.td?rev=138042&r1=138041&r2=138042&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMInstrThumb.td (original)
+++ llvm/trunk/lib/Target/ARM/ARMInstrThumb.td Fri Aug 19 11:52:32 2011
@@ -125,6 +125,11 @@
 
 // t_addrmode_rrs := reg + reg
 //
+// We use separate scaled versions because the Select* functions need
+// to explicitly check for a matching constant and return false here so that
+// the reg+imm forms will match instead. This is a horrible way to do that,
+// as it forces tight coupling between the methods, but it's how selectiondag
+// currently works.
 def t_addrmode_rrs1 : Operand<i32>,
                       ComplexPattern<i32, 2, "SelectThumbAddrModeRI5S1", []> {
   let EncoderMethod = "getThumbAddrModeRegRegOpValue";





More information about the llvm-commits mailing list