[llvm-commits] [llvm] r137845 - /llvm/trunk/test/FrontendC++/2010-02-17-DbgArtificialArg.cpp

[Eric Christopher]

On Aug 17, 2011, at 1:07 PM, Devang Patel wrote:

> 
> On Aug 17, 2011, at 12:58 PM, Eric Christopher wrote:
> 
>> How about this: what patch was this change testing?
> 
> I answered, what is the original intent of the test (also included as a comment in test case from day one). Today, I noticed that .ll printed by llvm-gcc is not including  metadata tags (e.g. "DW_TAG_pointer_type") in comments. Since the is meant to check is "artificial" bit on the debug info I updated it to check final .s output.

So the original intent of the test is to test that the output of the compiler is correct for metadata tags. Can you add the comment then in llvm-gcc as opposed to testing a set of things that doesn't make sense for a frontend test as well as splitting it out into a separate backend test to test that the artificial bit on the debug info is set with the output that you're expecting from the front end? That way it's tested in both places, but separately as more of a unit test.

-eric