[llvm-commits] [llvm] r137791 - in /llvm/trunk: include/llvm/Support/DynamicLibrary.h lib/Support/DynamicLibrary.cpp lib/Support/Windows/DynamicLibrary.inc

[Jordy Rose]

On Aug 17, 2011, at 5:00, NAKAMURA Takumi wrote:

> WTF Cygwin! On Cygwin, RTLD_DEFAULT is NULL. Then,
> DynamicLibrary::isValid() says Data(==RTLD_DEFAULT) might be invalid.

Ah...right. I made sure the (already-existing) logic for getPermanentLibrary() was correct here, but didn't think about what effect it would have on the instance later.


> A suggested patch is here. Feel free to modify and apply it. :)

I'm wary of using (void *)(-1) because someday someone might decide that (void *)(-1) is a great way to represent RTLD_NEXT. I'll use an existing address instead.

Thanks for catching this!
Jordy