[llvm-commits] [llvm] r137712 - in /llvm/trunk/lib: Analysis/ScalarEvolutionExpander.cpp Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp Transforms/Instrumentation/GCOVProfiling.cpp

[Bill Wendling]

On Aug 16, 2011, at 10:51 AM, Nick Lewycky wrote:
>         // call runtime to perform increment
> -        IRBuilder<> Builder(ComplexEdgeSuccs[i+1]->getFirstNonPHI());
> +        BasicBlock::iterator InsertPt = ComplexEdgeSuccs[i+1]->getFirstNonPHI();
> +        if (isa<LandingPadInst>(InsertPt)) ++InsertPt;
> +        IRBuilder<> Builder(InsertPt);
> 
> How about a method like getFirstNonPHI() but that skips landingpad called getFirstInsertPoint? The comment for such a method would be that it returns the earliest insertpt that does not have an ordering constraint in the IR?
> 
Not a bad idea. :)

-bw