[llvm-commits] [PATCH] Fixes in ARM TableGen

[Owen Anderson]

Looks good to me as well.  I'll go through and apply it piece-by-piece in a bit.

--Owen

On Aug 15, 2011, at 11:40 AM, Jim Grosbach wrote:

> 
> On Aug 15, 2011, at 11:37 AM, Eric Christopher wrote:
> 
>> 
>> On Aug 15, 2011, at 7:22 AM, James Molloy wrote:
>> 
>>> Hi,
>>> 
>>> The attached patch does three things (they're each so small I kept them in the same patch file - hope this is OK):
>>> 
>>> ·         Fix the field offsets for UMAAL - RdHi and RdLo were the incorrect way around (see A8.6.244). This required a fix to a test.
>>> ·         Set the DecoderMethod for STRH (and other addrmode3 stores) correctly.
>>> ·         Remove two pieces of dead code - class AI3stridx and class AIsthpr in ARMInstrFormats.td were not used anywhere.
>>> 
>>> Cheers,
>>> 
>>> James
>>> <STRH_UMAAL.patch>_______________________________________________
>> 
>> LGTM.
>> 
>> Any objections Jim?
> 
> 
> OK w/ me. I would prefer the changes be checked in as separate patches, though, even though they're very small. Keeps the revision history easier to follow.
> 
> -jim
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits