[llvm-commits] [PATCH] Fix decoding of 16-bit LDRSB

[James Molloy]

You guys beat me to it - typing on this Apple Generic Tablet can be slow ;)

Owen - theres a testcase for ldrsb, do you want one for ldrsh too? The change is identical to both which is why I left creating tests for both.

Up to you guys!


James



On 15 Aug 2011, at 19:54, "Eric Christopher" <echristo at apple.com<mailto:echristo at apple.com>> wrote:


On Aug 15, 2011, at 11:53 AM, Owen Anderson wrote:


On Aug 15, 2011, at 11:40 AM, Eric Christopher wrote:


On Aug 15, 2011, at 7:23 AM, James Molloy wrote:

Hi,

The attached patch fixes decoding of LDRSB and LDRSH in 16-bit Thumb mode. Testcase added.

Cheers,


   let EncoderMethod = "getThumbAddrModeRegRegOpValue";
   let PrintMethod = "printThumbAddrModeRROperand";
+  let DecoderMethod = "DecodeThumbAddrModeRR";
   let MIOperandInfo = (ops tGPR:$base, tGPR:$offsreg);
 }

This appears to be the actual fix and the rest is some random renaming? Also could you add a test for ldrsh as well?

No, the renaming is necessary because the auto-generated decoder emitter can only auto-generate operand parsers when the names match up.

Oh yuck, that's heinous.

-eric



-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.